CI/CD Build Fixes for Release #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI/CD workflows for various build types by replacing the previous method of setting environment variables via appending to $GITHUB_ENV with inline export commands in the build step.
- Removed the dedicated "Set environment variables" step
- Combined environment variable setup with the build command execution
- Updated four workflow files (.github/workflows/release.yml, release-candidate.yml, nightly.yml, development.yml) to use the export pattern
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Uses inline export commands for release builds |
| .github/workflows/release-candidate.yml | Uses inline export commands for release_candidate builds |
| .github/workflows/nightly.yml | Uses inline export commands for nightly builds |
| .github/workflows/development.yml | Uses inline export commands for dev builds, with build_number tied to pull_request.number |
Files not reviewed (1)
- tox.ini: Language not supported
|
Build artifacts (.whl and .tar.gz) are available for download for up to 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.